Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base segmentation on sidx or mfra if present #265

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

tobbee
Copy link
Collaborator

@tobbee tobbee commented Sep 5, 2023

mp4ff tries to find the init and media segment structure if present.
The sidx box helps by telling where segment start and how big they are.
This information is now used by reading the data from the first sidx box present, if any,
or from the first tfra box in an mfra box at the end of the file.

The search for an mfra box can be controlled with an option in the DecodeFile() call.

Solver #263 for the DASH OnDemand case where a sidx or mfra box is present.

@tobbee tobbee force-pushed the fix-segment-using-sidx branch from de69fd7 to 13c2ffc Compare September 5, 2023 15:09
@tobbee tobbee changed the title fix: start new segment based on sidx if sidx is present fix: base segmentation on sidx of mfra if present Sep 5, 2023
@tobbee tobbee force-pushed the fix-segment-using-sidx branch from 13c2ffc to 51a33ba Compare September 5, 2023 15:35
mp4/file.go Outdated Show resolved Hide resolved
mp4/file.go Outdated Show resolved Hide resolved
@tobbee tobbee force-pushed the fix-segment-using-sidx branch from 3b2c76a to 374d429 Compare September 6, 2023 06:49
@tobbee tobbee changed the title fix: base segmentation on sidx of mfra if present fix: base segmentation on sidx or mfra if present Sep 6, 2023
@tobbee tobbee merged commit 4470db0 into master Sep 6, 2023
7 checks passed
@tobbee tobbee deleted the fix-segment-using-sidx branch September 6, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants